Skip to content

feat(ml): add qdrant ingestion#38142

Open
MichaelGruschke wants to merge 1 commit intoapache:masterfrom
MichaelGruschke:qdrant
Open

feat(ml): add qdrant ingestion#38142
MichaelGruschke wants to merge 1 commit intoapache:masterfrom
MichaelGruschke:qdrant

Conversation

@MichaelGruschke
Copy link
Copy Markdown
Contributor

resolves #38141

This PR adds support for Qdrant vector database ingestion to Apache Beam's ML RAG pipeline.

Implementation details:

  1. QdrantConnectionParameters

    • Dataclass for Qdrant connection configuration
    • Supports location, url, host, path for connection
    • Configurable port, grpc_port, api_key, https, timeout
  2. QdrantWriteConfig

    • Extends VectorDatabaseWriteConfig
    • Supports both dense and sparse embeddings
    • Creates converter to models.PointStruct
    • Batched writes (default 1000 items/batch)
  3. QdrantWriteTransform

    • Private PTransform wrapping _QdrantWriteFn
    • Batches elements and upserts to Qdrant collection
    • Handles client lifecycle (setup/teardown)
  4. Dependency Changes

    • Added qdrant-client to ml_test extras_require

5.Tests

  • Integration tests (qdrant_it_test.py) for end-to-end ingestion verification

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances Apache Beam's machine learning capabilities by integrating Qdrant, a popular vector database. It provides a complete framework for ingesting embedded data into Qdrant collections, allowing for scalable and efficient management of vector embeddings within RAG pipelines. The changes include new configuration options, data transformation logic, and thorough testing to ensure reliability and correctness.

Highlights

  • Qdrant Integration: Added comprehensive support for Qdrant vector database ingestion within Apache Beam's ML RAG pipeline, enabling users to write EmbeddableItem objects to Qdrant collections.
  • Configuration Classes: Introduced QdrantConnectionParameters for defining connection details (location, URL, host, port, API key, etc.) and QdrantWriteConfig for specifying write behavior (collection name, batch size, embedding keys).
  • Data Transformation and Ingestion: Implemented _QdrantWriteTransform and _QdrantWriteFn to handle the conversion of EmbeddableItem objects into Qdrant's PointStruct format, supporting both dense and sparse embeddings, and performing batched upserts to the Qdrant collection.
  • Dependency Management: Updated setup.py to include qdrant-client as a new dependency, ensuring it's available for ML-related tests and installations.
  • Integration Tests: Provided robust integration tests (qdrant_it_test.py) to verify end-to-end Qdrant ingestion functionality, covering various scenarios like dense-only, sparse-only, hybrid embeddings, batching, and idempotent writes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@MichaelGruschke MichaelGruschke force-pushed the qdrant branch 2 times, most recently from 3a266b5 to efe7cf4 Compare April 10, 2026 22:33
@github-actions
Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

refactor: use local qdrant implementation for tests

chore: clean up imports

chore: add qdrant dependency to ml_test extra

chore: run precommit

chore: add comment to CHANGES.md

fix: guard against import error

fix: import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add Qdrant vector database ingestion support

1 participant