Skip to content

Bump log4j version to 2.25.4 #38210

Open
shunping wants to merge 2 commits intoapache:masterfrom
shunping:bump-log4j-version
Open

Bump log4j version to 2.25.4 #38210
shunping wants to merge 2 commits intoapache:masterfrom
shunping:bump-log4j-version

Conversation

@shunping
Copy link
Copy Markdown
Collaborator

@shunping shunping commented Apr 16, 2026

This is to fix CVE-2026-34477.

The beam-sdks-java-io-expansion-service shaded JAR was found to contain a vulnerable version of log4j-core (2.20.0), introduced transitively via org.apache.iceberg:iceberg-aws-bundle:1.10.0.

To resolve this, the change:

  1. Updates the global log4j version to 2.25.4.
  2. Enforces the inclusion of the patched log4j-core in the expansion service's shaded JAR to override the version bundled in iceberg-aws-bundle.

Internal bug id: 502837070

@shunping shunping changed the title Bump log4j-core to 2.25.4 Bump log4j version to 2.25.4 Apr 16, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a security vulnerability by upgrading the log4j-core library across the project. Additionally, it ensures that the expansion service's shaded jar includes the patched version of the library, effectively mitigating a risk introduced by a transitive dependency.

Highlights

  • Security Update: Updated log4j-core to version 2.25.4 to address CVE-2026-34477.
  • Dependency Enforcement: Explicitly added log4j-core as a runtime dependency in the expansion-service to override a vulnerable transitive dependency found in iceberg-aws-bundle.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@shunping
Copy link
Copy Markdown
Collaborator Author

r: @Abacn

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@shunping shunping mentioned this pull request Apr 16, 2026
3 tasks
@shunping
Copy link
Copy Markdown
Collaborator Author

r: @claudevdm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants