Skip to content

Comments

Add license-maven-plugin and some default license merges#3823

Closed
jbonofre wants to merge 1 commit intoapache:masterfrom
jbonofre:licensing-fixups
Closed

Add license-maven-plugin and some default license merges#3823
jbonofre wants to merge 1 commit intoapache:masterfrom
jbonofre:licensing-fixups

Conversation

@jbonofre
Copy link
Member

@jbonofre jbonofre commented Sep 8, 2017

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@jbonofre
Copy link
Member Author

jbonofre commented Sep 8, 2017

R: @davorbonaci

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 69.676% when pulling 5bede0a on jbonofre:licensing-fixups into 80c86f8 on apache:master.

Copy link
Member

@davorbonaci davorbonaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(please self-merge)

@asfgit asfgit closed this in c2dab4d Sep 10, 2017
@jbonofre jbonofre deleted the licensing-fixups branch September 10, 2017 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants