Skip to content

Revert #36781 Implement pluggable Lineage in Java SDK#38294

Closed
Abacn wants to merge 2 commits intoapache:masterfrom
Abacn:rev-36781
Closed

Revert #36781 Implement pluggable Lineage in Java SDK#38294
Abacn wants to merge 2 commits intoapache:masterfrom
Abacn:rev-36781

Conversation

@Abacn
Copy link
Copy Markdown
Contributor

@Abacn Abacn commented Apr 27, 2026

Please add a meaningful description for your change here

See #36781 (comment) for contexts.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions Bot added the java label Apr 27, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts the previously introduced pluggable lineage mechanism in the Java SDK. The change simplifies the lineage tracking implementation by removing the abstraction layer and directly utilizing metrics, which improves maintainability and reduces complexity in the codebase.

Highlights

  • Removal of Pluggable Lineage: Reverted the implementation of pluggable Lineage in the Java SDK, removing the LineageBase interface and associated infrastructure.
  • Refactoring Lineage Metrics: Simplified the Lineage class to directly manage metrics, removing the delegate pattern and reflection-based initialization.
  • Cleanup: Removed supporting classes, test utilities, and pipeline options related to the pluggable lineage mechanism.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Abacn Abacn marked this pull request as draft April 27, 2026 20:29
@Abacn
Copy link
Copy Markdown
Contributor Author

Abacn commented Apr 27, 2026

alternatively, a forward fix #38296

@Abacn Abacn closed this Apr 28, 2026
@Abacn Abacn deleted the rev-36781 branch April 28, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant