Skip to content

Set gemini config.yaml to post code review on PR open#38316

Merged
derrickaw merged 1 commit into
masterfrom
20260429_geminiConfigUpdate
Apr 29, 2026
Merged

Set gemini config.yaml to post code review on PR open#38316
derrickaw merged 1 commit into
masterfrom
20260429_geminiConfigUpdate

Conversation

@derrickaw
Copy link
Copy Markdown
Collaborator

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@derrickaw derrickaw marked this pull request as ready for review April 29, 2026 13:49
@github-actions
Copy link
Copy Markdown
Contributor

/gemini review

@stankiewicz stankiewicz self-requested a review April 29, 2026 13:49
@derrickaw derrickaw merged commit d8d99c4 into master Apr 29, 2026
3 checks passed
@derrickaw derrickaw deleted the 20260429_geminiConfigUpdate branch April 29, 2026 13:52
@jrmccluskey
Copy link
Copy Markdown
Contributor

Is there a reason we re-enabled this behavior? It's quite noisy to have this auto-run on every single PR at open, including trivial PRs that don't need it and PRs that are actively being iterated on.

@derrickaw derrickaw restored the 20260429_geminiConfigUpdate branch April 29, 2026 19:14
@derrickaw derrickaw deleted the 20260429_geminiConfigUpdate branch April 29, 2026 19:14
@derrickaw
Copy link
Copy Markdown
Collaborator Author

Is there a reason we re-enabled this behavior? It's quite noisy to have this auto-run on every single PR at open, including trivial PRs that don't need it and PRs that are actively being iterated on.

There was an offline discussion that there has been an uptick in poor quality PRs recently and it was suggested that we enable a Gemini review to attenuate this trend.

@derrickaw
Copy link
Copy Markdown
Collaborator Author

Hi @jrmccluskey, created a PR to not issue a review on draft PRs to address one of your concerns - #38333.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants