Skip to content

Deflake PreCommit Java and PostCommit Java Dataflow#38320

Open
Abacn wants to merge 2 commits intoapache:masterfrom
Abacn:deflake
Open

Deflake PreCommit Java and PostCommit Java Dataflow#38320
Abacn wants to merge 2 commits intoapache:masterfrom
Abacn:deflake

Conversation

@Abacn
Copy link
Copy Markdown
Contributor

@Abacn Abacn commented Apr 29, 2026

FileIOTest.testMatchWatchForNewFiles is very flaky, probably due to a heavy pipeline test 4 scenarios put into a single test. Consider split it into two test, for matchMetadata and matchAllUpdatedMetadata, construct and run pipeline; for matchAllMetadata and matchUpdatedMetadata, only construct pipeline and check the output PCollection is unbounded.

Previously it was testing full combination of two parameters. Picking two out of four covering all parameters the test coverage remains unchanged.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to improve the stability of the test suite by refactoring a flaky test case in FileIOTest. Additionally, it includes minor build configuration improvements for the DirectRunner and removes deprecated compatibility logic in the Python SDK to streamline the codebase.

Highlights

  • Test Stability: Split the flaky FileIOTest.testMatchWatchForNewFiles into two separate tests to improve reliability and maintain coverage.
  • Build Configuration: Updated Gradle tasks in runners/direct-java/build.gradle to use tasks.register for better performance and configuration avoidance.
  • Python SDK Cleanup: Removed legacy compatibility code for Apache Beam versions prior to 2.73.0 in sdks/python/apache_beam/transforms/core.py.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates Gradle task registrations to use the configuration avoidance API and refactors Java tests in FileIOTest.java to separate boundedness checks. Feedback highlights a critical regression in the Python SDK where version-specific logic was accidentally deleted and identifies that the new Java test will fail without disabling abandoned node enforcement since it lacks a run() call.

Comment thread sdks/python/apache_beam/transforms/core.py Outdated
Comment thread sdks/java/core/src/test/java/org/apache/beam/sdk/io/FileIOTest.java
@Abacn Abacn changed the title Deflake testMatchWatchForNewFiles Deflake PreCommit Java and PostCommit Java Dataflow Apr 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit Java Dataflow V1 job is flaky

1 participant