Deflake PreCommit Java and PostCommit Java Dataflow#38320
Deflake PreCommit Java and PostCommit Java Dataflow#38320Abacn wants to merge 2 commits intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to improve the stability of the test suite by refactoring a flaky test case in FileIOTest. Additionally, it includes minor build configuration improvements for the DirectRunner and removes deprecated compatibility logic in the Python SDK to streamline the codebase. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates Gradle task registrations to use the configuration avoidance API and refactors Java tests in FileIOTest.java to separate boundedness checks. Feedback highlights a critical regression in the Python SDK where version-specific logic was accidentally deleted and identifies that the new Java test will fail without disabling abandoned node enforcement since it lacks a run() call.
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
FileIOTest.testMatchWatchForNewFiles is very flaky, probably due to a heavy pipeline test 4 scenarios put into a single test. Consider split it into two test, for matchMetadata and matchAllUpdatedMetadata, construct and run pipeline; for matchAllMetadata and matchUpdatedMetadata, only construct pipeline and check the output PCollection is unbounded.
Previously it was testing full combination of two parameters. Picking two out of four covering all parameters the test coverage remains unchanged.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.