Revert "Add DiskProvisionedIops/ThroughputMibps options and update Go…#38321
Revert "Add DiskProvisionedIops/ThroughputMibps options and update Go…#38321
Conversation
|
R: @jrmccluskey cc/ @bambadiouf1 (if you put up a PR adding back the Java/Go pieces I can quickly approve) |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a complete reversion of a previous commit that introduced new disk provisioning options for Dataflow runners in the Java, Python, and Go SDKs. This action removes the associated code, configuration, and dependency updates that were part of the original feature, effectively rolling back the system to its state before the introduction of these specific disk customization capabilities. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes support for configuring disk provisioned IOPS and throughput across the Java, Go, and Python SDKs, including the removal of associated pipeline options, translator logic, and tests. Additionally, it downgrades several Google Cloud and OpenTelemetry dependencies in the Go SDK and updates the autogenerated Dataflow API client in Python. A potential issue was identified in the Go runner where the removal of a nil check for pipeline options could result in a runtime panic.
| if opts.Options.Options == nil { | ||
| opts.Options.Options = make(map[string]string) | ||
| } | ||
| opts.Options.Options["experiments"] = strings.Join(opts.Experiments, ",") |
There was a problem hiding this comment.
Removing the nil check for opts.Options.Options introduces a potential panic if the map is not initialized. Even if current callers ensure initialization, keeping this check makes the Translate function more robust against future changes or external calls.
if opts.Options.Options == nil {
opts.Options.Options = make(map[string]string)
}
opts.Options.Options["experiments"] = strings.Join(opts.Experiments, ",")|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
… client libraries (#37377)"
This reverts commit 7910b1b.
Context: #37377 (comment)
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.