Skip to content

Revert "Add DiskProvisionedIops/ThroughputMibps options and update Go…#38321

Merged
damccorm merged 1 commit intomasterfrom
users/damccorm/revertClientChanges
Apr 29, 2026
Merged

Revert "Add DiskProvisionedIops/ThroughputMibps options and update Go…#38321
damccorm merged 1 commit intomasterfrom
users/damccorm/revertClientChanges

Conversation

@damccorm
Copy link
Copy Markdown
Contributor

… client libraries (#37377)"

This reverts commit 7910b1b.

Context: #37377 (comment)


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm
Copy link
Copy Markdown
Contributor Author

R: @jrmccluskey

cc/ @bambadiouf1 (if you put up a PR adding back the Java/Go pieces I can quickly approve)

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a complete reversion of a previous commit that introduced new disk provisioning options for Dataflow runners in the Java, Python, and Go SDKs. This action removes the associated code, configuration, and dependency updates that were part of the original feature, effectively rolling back the system to its state before the introduction of these specific disk customization capabilities.

Highlights

  • Reverted Dataflow Disk Provisioning Options: The pull request fully reverts the addition of DiskProvisionedIops and DiskProvisionedThroughputMibps options across Java, Python, and Go Dataflow SDKs.
  • Go Client Library Downgrade: Several Go client libraries and related dependencies were reverted to their previous versions, undoing recent updates.
  • Java Dataflow API Version Reversion: The google_api_services_dataflow version in the Gradle build configuration was reverted to an older revision.
  • Removed Changelog Entry: The entry in CHANGES.md documenting the addition of disk provisioned IOPS and throughput support was removed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes support for configuring disk provisioned IOPS and throughput across the Java, Go, and Python SDKs, including the removal of associated pipeline options, translator logic, and tests. Additionally, it downgrades several Google Cloud and OpenTelemetry dependencies in the Go SDK and updates the autogenerated Dataflow API client in Python. A potential issue was identified in the Go runner where the removal of a nil check for pipeline options could result in a runtime panic.

if opts.Options.Options == nil {
opts.Options.Options = make(map[string]string)
}
opts.Options.Options["experiments"] = strings.Join(opts.Experiments, ",")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Removing the nil check for opts.Options.Options introduces a potential panic if the map is not initialized. Even if current callers ensure initialization, keeping this check makes the Translate function more robust against future changes or external calls.

	if opts.Options.Options == nil {
		opts.Options.Options = make(map[string]string)
	}
	opts.Options.Options["experiments"] = strings.Join(opts.Experiments, ",")

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@damccorm damccorm merged commit 0739dbb into master Apr 29, 2026
113 of 125 checks passed
@damccorm damccorm deleted the users/damccorm/revertClientChanges branch April 29, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants