Revert "remove processContext usage across examples (java and kotlin)" by Abacn · Pull Request #38341 · apache/beam

Abacn · 2026-04-30T15:01:49Z

Large generated PR had hidden mistakes and broke tests

…#37937)" This reverts commit 4151dde.

Abacn · 2026-04-30T15:02:15Z

gemini-code-assist · 2026-04-30T15:03:06Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a previous large-scale refactoring that attempted to modernize Apache Beam DoFn methods by removing ProcessContext in favor of parameter injection. The revert is necessary because the previous changes introduced regressions and broke existing tests, necessitating a return to the stable, albeit more verbose, ProcessContext pattern.

Highlights

Revert of ProcessContext removal: This pull request reverts the changes that removed ProcessContext usage across various Java and Kotlin examples, as the previous implementation contained hidden errors and caused test failures.
Cleanup of unused imports: Removed unused imports related to DoFn.Element, DoFn.OutputReceiver, and DoFn.Timestamp across multiple files.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request reverts modern Apache Beam DoFn parameter injection to the legacy ProcessContext style across numerous Java and Kotlin examples and removes the modernizer documentation. The review feedback identifies several inconsistencies introduced by this change, including redundant method signatures that mix legacy and modern parameters, and logic errors where null checks incorrectly lead to null outputs. Recommendations were made to maintain a consistent API style and simplify signatures by using direct parameter injection for PipelineOptions where appropriate.

gemini-code-assist · 2026-04-30T15:06:03Z

+      if (map == null) {
+        c.output(c.element());
+        return;
+      }


The logic here is redundant and potentially problematic. If map is null, calling c.output(c.element()) will output a null value, which might cause issues with downstream transforms or coders. If the intention is to skip null elements, the method should simply return. If the intention is to pass them through, it is more efficient to use the local variable map instead of calling c.element() again.

if (map == null) { return; }

gemini-code-assist · 2026-04-30T15:06:03Z

+                      ProcessContext c, OutputReceiver<KV<Integer, Integer>> out) {
                    System.out.printf(
-                        "Vendor: %s, Passengers: %s%n", element.getKey(), element.getValue());
-                    out.output(element);
+                        "Vendor: %s, Passengers: %s%n",
+                        c.element().getKey(), c.element().getValue());
+                    out.output(c.element());


This method signature mixes legacy ProcessContext with the modern OutputReceiver parameter. For consistency and clarity, it is recommended to use one style. Since this PR is reverting to ProcessContext, you should use c.output() instead of the out parameter.

Suggested change

ProcessContext c, OutputReceiver<KV<Integer, Integer>> out) {

System.out.printf(

"Vendor: %s, Passengers: %s%n", element.getKey(), element.getValue());

out.output(element);

"Vendor: %s, Passengers: %s%n",

c.element().getKey(), c.element().getValue());

out.output(c.element());

ProcessContext c) {

System.out.printf(

"Vendor: %s, Passengers: %s%n",

c.element().getKey(), c.element().getValue());

c.output(c.element());

gemini-code-assist · 2026-04-30T15:06:03Z

+    public void process(@Element KV<Integer, Iterable<Row>> element, ProcessContext context) {
      Iterable<Row> rows = element.getValue();


Mixing @Element parameter injection with ProcessContext is redundant and inconsistent. Since ProcessContext is being used for output later in the method, it should also be used to access the element via context.element() for a consistent API usage style.

Suggested change

public void process(@Element KV<Integer, Iterable<Row>> element, ProcessContext context) {

Iterable<Row> rows = element.getValue();

public void process(ProcessContext context) {

Iterable<Row> rows = context.element().getValue();

gemini-code-assist · 2026-04-30T15:06:03Z

+        @Element Row in, OutputReceiver<KV<ByteString, Iterable<Mutation>>> out, ProcessContext c) {
+      DataTokenizationOptions options = c.getPipelineOptions().as(DataTokenizationOptions.class);


The ProcessContext parameter is only used here to access PipelineOptions. In Apache Beam, PipelineOptions can be injected directly as a parameter to @ProcessElement. Mixing ProcessContext with modern parameters like @Element and OutputReceiver is discouraged as it makes the method signature unnecessarily complex.

public void processElement( @Element Row in, OutputReceiver<KV<ByteString, Iterable<Mutation>>> out, PipelineOptions pipelineOptions) { DataTokenizationOptions options = pipelineOptions.as(DataTokenizationOptions.class);

gemini-code-assist · 2026-04-30T15:06:03Z


    @ProcessElement
-    public void processElement(@Element ReadableFile file, MultiOutputReceiver outputReceiver) {
+    public void processElement(ProcessContext context, MultiOutputReceiver outputReceiver) {


This method signature contains both ProcessContext and MultiOutputReceiver. This is redundant because ProcessContext already provides the ability to output to multiple tags via context.output(tag, value). For consistency, especially in a PR reverting to legacy context usage, the MultiOutputReceiver parameter should be removed.

Suggested change

public void processElement(ProcessContext context, MultiOutputReceiver outputReceiver) {

public void processElement(ProcessContext context) {

Abacn · 2026-04-30T15:23:17Z

R: @Amar3tto cc: @stankiewicz we can roll forward after master branch getting a good commit range

github-actions · 2026-04-30T15:24:43Z

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Revert "remove processContext usage across examples (java and kotlin) (…

3ddfe07

…#37937)" This reverts commit 4151dde.

github-actions Bot added java examples kotlin labels Apr 30, 2026

Abacn mentioned this pull request Apr 30, 2026

Fix Playground CI Nightly job #38327

Closed

3 tasks

gemini-code-assist Bot reviewed Apr 30, 2026

View reviewed changes

Restore SKILLs.md as it does not affect Beam playground

c782069

Amar3tto approved these changes May 1, 2026

View reviewed changes

stankiewicz merged commit e530809 into master May 1, 2026
16 of 19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "remove processContext usage across examples (java and kotlin)"#38341

Revert "remove processContext usage across examples (java and kotlin)"#38341
stankiewicz merged 2 commits intomasterfrom
revert-37937-eradicate_processContext_usage_examples

Abacn commented Apr 30, 2026

Uh oh!

Abacn commented Apr 30, 2026

Uh oh!

gemini-code-assist Bot commented Apr 30, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Uh oh!

Abacn commented Apr 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		public void process(@Element KV<Integer, Iterable<Row>> element, ProcessContext context) {
		Iterable<Row> rows = element.getValue();

		@Element Row in, OutputReceiver<KV<ByteString, Iterable<Mutation>>> out, ProcessContext c) {
		DataTokenizationOptions options = c.getPipelineOptions().as(DataTokenizationOptions.class);

	public void processElement(ProcessContext context, MultiOutputReceiver outputReceiver) {
	public void processElement(ProcessContext context) {

Conversation

Abacn commented Apr 30, 2026

Uh oh!

Abacn commented Apr 30, 2026

Uh oh!

gemini-code-assist Bot commented Apr 30, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Abacn commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Abacn commented Apr 30, 2026 •

edited

Loading