Skip to content

Remove unused variable #38360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Amar3tto wants to merge 1 commit into from
Closed

Remove unused variable #38360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2091,7 +2091,6 @@ static class GenerateKafkaSourceDescriptor extends DoFn<byte[], KafkaSourceDescr
this.topicPattern = read.getTopicPattern();
this.startReadTime = read.getStartReadTime();
this.stopReadTime = read.getStopReadTime();
this.logTopicVerification = read.getLogTopicVerification();
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logTopicVerification variable and its associated configuration methods (e.g., withLogTopicVerification, getLogTopicVerification) likely still exist in the KafkaIO.Read class. If this variable is truly unused across the entire KafkaIO transform, it should also be removed from the Read class to maintain a clean and consistent public API.

}

private final SerializableFunction<Map<String, Object>, Consumer<byte[], byte[]>>
Expand All @@ -2108,7 +2107,6 @@ static class GenerateKafkaSourceDescriptor extends DoFn<byte[], KafkaSourceDescr
@VisibleForTesting final @Nullable List<String> topics;

private final @Nullable Pattern topicPattern;
private final @Nullable Boolean logTopicVerification;
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The remaining field declarations in this class (such as topics and topicPattern) are scattered after the constructor. For better maintainability, these should be grouped together at the beginning of the class.


@ProcessElement
public void processElement(OutputReceiver<KafkaSourceDescriptor> receiver) {
Expand Down
Loading