Revert "[yaml] - Add huggingface model handler"#38421
Conversation
derrickaw
commented
May 8, 2026
- Reverts [yaml] - Add huggingface model handler #38110
- The previous PR also made changes to build files and suspect thats whats causing the dependency resolution too deep error occurring since yesterday afternoon - https://github.com/apache/beam/actions/workflows/beam_PreCommit_Yaml_Xlang_Direct.yml
This reverts commit 422f630.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reverts the recent addition of the HuggingFace model handler in the Apache Beam YAML module. The change is intended to resolve dependency resolution issues observed in the pre-commit CI pipelines that were introduced alongside the new feature. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the HuggingFacePipeline provider from Beam YAML, deletes its corresponding integration test, and removes the installYamlIntegrationTestDeps Gradle task. The reviewer pointed out that completely removing the dependency installation task might cause other YAML integration tests to fail, as they still require the yaml and ml_test extras. It is recommended to retain the task while only excluding the problematic transformers dependency.
I am having trouble creating individual review comments. Click here to see my feedback.
sdks/python/build.gradle (127-135)
Removing the installYamlIntegrationTestDeps task entirely also removes the installation of the yaml and ml_test extras. While the transformers extra was likely the cause of the dependency resolution issues mentioned in the PR description, the remaining YAML integration tests (such as yamlIntegrationTests and postCommitYamlIntegrationTests) likely still require the yaml and ml_test extras to function correctly.
Reverting these tasks to depend only on installGcpTest may cause them to fail in CI if the yaml module or its dependencies are not included in the standard test extras. Consider keeping the helper task but removing only the transformers extra from the pip install command.
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |