Skip to content

Revert "[yaml] - Add huggingface model handler"#38421

Merged
derrickaw merged 1 commit intomasterfrom
revert-38110-20260408_huggingFaceYaml
May 8, 2026
Merged

Revert "[yaml] - Add huggingface model handler"#38421
derrickaw merged 1 commit intomasterfrom
revert-38110-20260408_huggingFaceYaml

Conversation

@derrickaw
Copy link
Copy Markdown
Collaborator

  1. Reverts [yaml] - Add huggingface model handler #38110
  2. The previous PR also made changes to build files and suspect thats whats causing the dependency resolution too deep error occurring since yesterday afternoon - https://github.com/apache/beam/actions/workflows/beam_PreCommit_Yaml_Xlang_Direct.yml

@derrickaw derrickaw marked this pull request as ready for review May 8, 2026 20:10
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts the recent addition of the HuggingFace model handler in the Apache Beam YAML module. The change is intended to resolve dependency resolution issues observed in the pre-commit CI pipelines that were introduced alongside the new feature.

Highlights

  • Reversion of HuggingFace Model Handler: Removed the recently added HuggingFacePipeline model handler support from the YAML ML module.
  • Build Configuration Cleanup: Removed the dedicated installation task for YAML integration test dependencies and reverted the integration test tasks to use the standard GCP test installation.
  • Test Suite Adjustments: Removed the HuggingFace-specific YAML test file and renamed the existing VertexAI test file.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/beam_PostCommit_Yaml_Xlang_Direct.yml
    • .github/workflows/beam_PreCommit_Yaml_Xlang_Direct.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@derrickaw derrickaw requested a review from damccorm May 8, 2026 20:11
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the HuggingFacePipeline provider from Beam YAML, deletes its corresponding integration test, and removes the installYamlIntegrationTestDeps Gradle task. The reviewer pointed out that completely removing the dependency installation task might cause other YAML integration tests to fail, as they still require the yaml and ml_test extras. It is recommended to retain the task while only excluding the problematic transformers dependency.

I am having trouble creating individual review comments. Click here to see my feedback.

sdks/python/build.gradle (127-135)

medium

Removing the installYamlIntegrationTestDeps task entirely also removes the installation of the yaml and ml_test extras. While the transformers extra was likely the cause of the dependency resolution issues mentioned in the PR description, the remaining YAML integration tests (such as yamlIntegrationTests and postCommitYamlIntegrationTests) likely still require the yaml and ml_test extras to function correctly.

Reverting these tasks to depend only on installGcpTest may cause them to fail in CI if the yaml module or its dependencies are not included in the standard test extras. Consider keeping the helper task but removing only the transformers extra from the pip install command.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@derrickaw derrickaw merged commit b60082d into master May 8, 2026
123 of 128 checks passed
@derrickaw derrickaw deleted the revert-38110-20260408_huggingFaceYaml branch May 8, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants