Skip to content

Isolate tests in multi_process_shared with unique temp path.#38498

Open
shunping wants to merge 2 commits into
apache:masterfrom
shunping:fix-flaky-test-1
Open

Isolate tests in multi_process_shared with unique temp path.#38498
shunping wants to merge 2 commits into
apache:masterfrom
shunping:fix-flaky-test-1

Conversation

@shunping
Copy link
Copy Markdown
Collaborator

@shunping shunping commented May 14, 2026

Flaky tests:

These tests were failing intermittently in parallel runs because setUp was cleaning up shared files in the default temp directory, including the ones created by any on-going tests, which interferes with concurrent tests.

This fix adds an autouse pytest fixture to force all MultiProcessShared instances to use a unique tmp_path per test, and removes the unsafe global cleanup in setUp.

@shunping shunping force-pushed the fix-flaky-test-1 branch from 4a61e84 to af38047 Compare May 14, 2026 05:22
@shunping shunping changed the title Fix flaky test test_transient_connection_error_recovery Isolate tests in multi_process_shared with unique temp path. May 14, 2026
@shunping shunping marked this pull request as ready for review May 14, 2026 05:28
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses flaky tests in the multi_process_shared module by improving test isolation. By replacing shared temporary directory usage with unique paths per test and removing problematic global cleanup routines, the changes ensure that concurrent test runs do not conflict with one another.

Highlights

  • Test Isolation: Introduced an autouse pytest fixture to ensure each test case uses a unique temporary directory, preventing cross-test interference.
  • Cleanup Refactoring: Removed the unsafe global cleanup logic in the setUp method that was causing intermittent failures during parallel test execution.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a pytest fixture to isolate MultiProcessShared tests by injecting a unique temporary directory path during initialization, enabling safer parallel execution. It also removes manual cleanup logic from MultiProcessSharedSpawnProcessTest. Feedback was provided regarding the fragility of the mock_init implementation, specifically concerning positional arguments and explicit None values for the path parameter, with a suggestion for a more robust function signature.

Comment thread sdks/python/apache_beam/utils/multi_process_shared_test.py
@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@shunping
Copy link
Copy Markdown
Collaborator Author

PreCommit Python ML tests failed on master, so it seems irrelevant to this change.
https://github.com/apache/beam/actions/runs/25852926419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant