Fix Python Flink PVR#38531
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a regression in Python Flink PVR tests caused by an upgrade to Jackson 2.14+. By moving away from a static, shared deserialization context and instead creating fresh, parser-associated contexts during deserialization, the changes resolve NullPointerExceptions that occurred when deserializers attempted to access transient parser fields. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
There was a problem hiding this comment.
Code Review
This pull request addresses potential NullPointerExceptions in Jackson 2.14+ by ensuring that DefaultDeserializationContext is properly initialized with a parser instead of using the copy() method, which leaves the transient parser field null. The changes are applied in PipelineOptionsFactory.java within the computeDeserializerForMethod and deserializeNode methods. Feedback from the review suggests centralizing the context creation logic into a private helper method to reduce code duplication and improve maintainability.
fixes #36326
The workflow (https://github.com/apache/beam/actions/workflows/beam_PreCommit_Python_PVR_Flink.yml) started to fail after #37969.