[yaml] - expand jinja method#38547
Conversation
3139622 to
064f8c2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38547 +/- ##
=========================================
Coverage 58.72% 58.73%
Complexity 7418 7418
=========================================
Files 1649 1649
Lines 212354 212415 +61
Branches 6330 6330
=========================================
+ Hits 124712 124763 +51
- Misses 83097 83107 +10
Partials 4545 4545
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for Jinja search paths and comment stripping in Beam YAML templates. Key changes include updating _BeamFileIOLoader to resolve relative paths using provided search paths and implementing strip_leading_comments to handle license headers in templates. Feedback highlights a missing shutil import in the new tests, suggests using os.path.isabs() for cross-platform path validation, and recommends avoiding bare exception handling when loading files.
064f8c2 to
7a9ce50
Compare
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.