Skip to content

Disable grpc fork support on some test suites. #38566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunping merged 3 commits into from
May 20, 2026
Merged

Disable grpc fork support on some test suites. #38566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6720d11
Disable grpc fork support in some test suite.
shunping May 19, 2026
2444642
Disable GRPC fork support.
shunping May 20, 2026
c07f019
Add TODOs
shunping May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions sdks/python/apache_beam/runners/portability/portable_runner_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import inspect
import logging
import os
import socket
import subprocess
import sys
Expand Down Expand Up @@ -328,6 +329,22 @@ class PortableRunnerTestWithSubprocessesAndMultiWorkers(
PortableRunnerTestWithSubprocesses):
_use_subprocesses = True

# TODO(https://github.com/grpc/grpc/issues/37710): Remove once fixed.
@classmethod
def setUpClass(cls):
cls._old_fork_support = os.environ.get('GRPC_ENABLE_FORK_SUPPORT')
os.environ['GRPC_ENABLE_FORK_SUPPORT'] = 'false'
super().setUpClass()

# TODO(https://github.com/grpc/grpc/issues/37710): Remove once fixed.
@classmethod
def tearDownClass(cls):
if cls._old_fork_support is None:
os.environ.pop('GRPC_ENABLE_FORK_SUPPORT', None)
else:
os.environ['GRPC_ENABLE_FORK_SUPPORT'] = cls._old_fork_support
super().tearDownClass()
Comment thread
shunping marked this conversation as resolved.

def create_options(self):
options = super() \
.create_options()
Expand Down
17 changes: 17 additions & 0 deletions sdks/python/apache_beam/utils/subprocess_server_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,23 @@


class JavaJarServerTest(unittest.TestCase):

# TODO(https://github.com/grpc/grpc/issues/37710): Remove once fixed.
@classmethod
def setUpClass(cls):
cls._old_fork_support = os.environ.get('GRPC_ENABLE_FORK_SUPPORT')
Comment thread
shunping marked this conversation as resolved.
os.environ['GRPC_ENABLE_FORK_SUPPORT'] = 'false'
super().setUpClass()

# TODO(https://github.com/grpc/grpc/issues/37710): Remove once fixed.
@classmethod
def tearDownClass(cls):
if cls._old_fork_support is None:
os.environ.pop('GRPC_ENABLE_FORK_SUPPORT', None)
else:
os.environ['GRPC_ENABLE_FORK_SUPPORT'] = cls._old_fork_support
super().tearDownClass()
Comment thread
shunping marked this conversation as resolved.

def test_gradle_jar_release(self):
self.assertEqual(
'https://repo.maven.apache.org/maven2/org/apache/beam/'
Expand Down
Loading