Skip to content

[BEAM-2837] Updated grpc-google-pubsub-v1 dependency#3862

Closed
mairbek wants to merge 4 commits intoapache:masterfrom
mairbek:deps
Closed

[BEAM-2837] Updated grpc-google-pubsub-v1 dependency#3862
mairbek wants to merge 4 commits intoapache:masterfrom
mairbek:deps

Conversation

@mairbek
Copy link
Contributor

@mairbek mairbek commented Sep 18, 2017

Updated grpc-google-pubsub-v1 dependency.

R: @jkff

@robertwb
Copy link
Contributor

Motivation?

@mairbek
Copy link
Contributor Author

mairbek commented Sep 19, 2017

@robertwb to fix BEAM-2837. Cloud Spanner expects grpc-google-common-protos of version 0.1.8, otherwise fails in runtime.

@mairbek mairbek changed the title [BEAM-2837] Exclude grpc-google-common-protos:0.1.0 dependency [BEAM-2837] Updated grpc-google-pubsub-v1 dependency Sep 19, 2017
@jkff
Copy link
Contributor

jkff commented Sep 19, 2017

Mairbek confirmed that a Dataflow pipeline reading and writing to pubsub works with this PR, but for extra safety I'm gonna run ValidatesRunner tests before merging.

@jkff
Copy link
Contributor

jkff commented Sep 19, 2017

Run Dataflow ValidatesRunner

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.549% when pulling 8c54b6e on mairbek:deps into 5dab9e1 on apache:master.

@asfgit asfgit closed this in e8a5282 Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants