Skip to content

[BEAM-2834] Ensure that we never pass in a null retry policy#3864

Closed
reuvenlax wants to merge 3 commits intoapache:masterfrom
reuvenlax:BEAM-2834
Closed

[BEAM-2834] Ensure that we never pass in a null retry policy#3864
reuvenlax wants to merge 3 commits intoapache:masterfrom
reuvenlax:BEAM-2834

Conversation

@reuvenlax
Copy link
Contributor

@reuvenlax reuvenlax commented Sep 19, 2017

R: @jkff

jkff
jkff requested changes Sep 19, 2017
View reviewed changes
Copy link
Contributor

@jkff jkff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you add a test?

@reuvenlax
Copy link
Contributor Author

reuvenlax commented Sep 20, 2017

@jkff added a test.

@coveralls
Copy link

coveralls commented Sep 20, 2017

Coverage Status

Coverage decreased (-0.003%) to 69.553% when pulling bf5c6ca on reuvenlax:BEAM-2834 into e8a5282 on apache:master.

jkff
jkff approved these changes Sep 21, 2017
View reviewed changes
Copy link
Contributor

@jkff jkff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM for self-merge.

@reuvenlax
Copy link
Contributor Author

reuvenlax commented Sep 22, 2017

This closes #3864

@reuvenlax reuvenlax closed this Oct 2, 2017
@reuvenlax reuvenlax deleted the BEAM-2834 branch December 9, 2018 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkff jkff jkff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reuvenlax @coveralls @jkff