Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/trigger_files/beam_PostCommit_Python_Versions.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run",
"revision": 4
"revision": 5
}
1 change: 1 addition & 0 deletions runners/prism/java/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ def sickbayTests = [
def createPrismValidatesRunnerTask = { name, environmentType ->
Task vrTask = tasks.create(name: name, type: Test, group: "Verification") {
description "PrismRunner Java $environmentType ValidatesRunner suite"
outputs.upToDateWhen { false }
classpath = configurations.validatesRunner

var prismBuildTask = dependsOn(':runners:prism:build')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -387,8 +387,11 @@ func (em *ElementManager) Bundles(ctx context.Context, upstreamCancelFn context.
em.pendingElements.Wait()
slog.Debug("no more pending elements: terminating pipeline")
cancelFn(fmt.Errorf("elementManager out of elements, cleaning up"))
// Ensure the watermark evaluation goroutine exits.
// Ensure the watermark evaluation goroutine exits by locking the mutex
// before broadcasting, preventing a lost wake-up signal.
em.refreshCond.L.Lock()
em.refreshCond.Broadcast()
em.refreshCond.L.Unlock()
}()
// Watermark evaluation goroutine.
go func() {
Expand Down Expand Up @@ -2496,7 +2499,9 @@ func (em *ElementManager) wakeUpAt(t mtime.Time) {
// only create this goroutine if we have real-time clock enabled (also implying the pipeline does not have TestStream).
go func(fireAt time.Time) {
time.AfterFunc(time.Until(fireAt), func() {
em.refreshCond.L.Lock()
em.refreshCond.Broadcast()
em.refreshCond.L.Unlock()
Comment thread
shunping marked this conversation as resolved.
})
}(t.ToTime())
}
Expand Down
Loading