Skip to content

Fix internal test configuration for Dataflow client #38792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrmccluskey merged 1 commit into from
Jun 3, 2026
+1 −1
Merged

Fix internal test configuration for Dataflow client #38792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ def __init__(self, options, root_staging_location=None):
transport = None
if self.google_cloud_options.dataflow_endpoint:
endpoint = self.google_cloud_options.dataflow_endpoint
if 'localhost' in endpoint:
if 'localhost' in endpoint or 'sandbox' in endpoint:
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The substring checks for 'localhost' and 'sandbox' are case-sensitive. If the endpoint URL contains uppercase characters (e.g., Localhost or Sandbox), this check will fail. Converting the endpoint to lowercase before performing the substring check ensures robustness.

Suggested change
if 'localhost' in endpoint or 'sandbox' in endpoint:
if 'localhost' in endpoint.lower() or 'sandbox' in endpoint.lower():

transport = 'rest'
else:
endpoint = re.sub('^https?://', '', endpoint)
Expand Down
Loading