[BigQuery] appends to tables can be asynchronous when doing copy jobs#39120
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes BigQuery data loading by removing the requirement for synchronous job completion when appending data to tables. By allowing these copy jobs to run asynchronously, the pipeline can improve throughput and reduce latency during write operations. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the BigQuery file loads logic to determine whether to wait for a job based on the write disposition, specifically setting wait_for_job to false when the disposition is 'WRITE_APPEND'. It also triggers the Python post-commit test suite. The review feedback recommends using the BigQueryDisposition.WRITE_APPEND constant instead of a hardcoded string to avoid magic strings and maintain consistency.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| if full_table_ref not in self._observed_tables: | ||
| write_disposition = self.write_disposition | ||
| wait_for_job = True | ||
| wait_for_job = write_disposition != 'WRITE_APPEND' |
There was a problem hiding this comment.
Using the BigQueryDisposition.WRITE_APPEND constant instead of the hardcoded string 'WRITE_APPEND' is preferred to avoid magic strings and maintain consistency with the rest of the codebase.
| wait_for_job = write_disposition != 'WRITE_APPEND' | |
| wait_for_job = write_disposition != BigQueryDisposition.WRITE_APPEND |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #39120 +/- ##
============================================
+ Coverage 58.62% 58.67% +0.05%
Complexity 15246 15246
============================================
Files 2769 2770 +1
Lines 275617 276050 +433
Branches 12163 12163
============================================
+ Hits 161577 161974 +397
- Misses 107621 107657 +36
Partials 6419 6419
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
2 participants
When write disposition is 'appends', there is no need to for each job to be synchronous.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.