Skip to content

[BEAM-2999] Move ValidatesRunner test out of Python postcommit#3927

Closed
markflyhigh wants to merge 5 commits intoapache:masterfrom
markflyhigh:python-split-postcommit
Closed

[BEAM-2999] Move ValidatesRunner test out of Python postcommit#3927
markflyhigh wants to merge 5 commits intoapache:masterfrom
markflyhigh:python-split-postcommit

Conversation

@markflyhigh
Copy link
Contributor

@markflyhigh markflyhigh commented Sep 30, 2017

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Create separate Jenkins build for Python validatesrunner tests and move them out of beam_PostCommit_Python_Verify.

beam_PostCommit_Python_Verify is pretty heavy combining with unit tests, validatesrunner tests and end-to-end tests, and the total time increase to 1 hour recently. This change can reduce the load of beam_PostCommit_Python_Verify and log will be cleaner for debugging if either build failed.

@markflyhigh
Copy link
Contributor Author

Run Seed Job

@markflyhigh
Copy link
Contributor Author

Run Seed Job

@markflyhigh
Copy link
Contributor Author

Run Python Dataflow ValidatesRunner

@markflyhigh
Copy link
Contributor Author

markflyhigh commented Oct 3, 2017

+R: @aaltay

@aaltay
Copy link
Member

aaltay commented Oct 3, 2017

Thank you @markflyhigh. I left a question for you.

@markflyhigh
Copy link
Contributor Author

@aaltay um.. where is the question? looks like comments and JIRA are empty...

@@ -70,22 +70,6 @@ SDK_LOCATION=$(find dist/apache-beam-*.tar.gz)
echo "pyhamcrest" > postcommit_requirements.txt
echo "mock" >> postcommit_requirements.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still use postcommit_requirements.txt in this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the catch. I checked existing validatesrunner tests and none of them use pyhamcrest and mock. Will remove it.

@aaltay
Copy link
Member

aaltay commented Oct 3, 2017

Forgot to post the question :), please take a look again.

@markflyhigh
Copy link
Contributor Author

Run Python Dataflow ValidatesRunner

@aaltay
Copy link
Member

aaltay commented Oct 3, 2017

LGTM. I can merge after tests pass. Could you also run the modified post commit tests?

@markflyhigh
Copy link
Contributor Author

markflyhigh commented Oct 3, 2017

@aaltay I mistakenly remove hamcrest and mock from VR test. Should remove from run_post_commit.sh. Will fix this and rerun both two tests.

@markflyhigh
Copy link
Contributor Author

Run Python Dataflow ValidatesRunner

@markflyhigh
Copy link
Contributor Author

Run Python PostCommit

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b7a116e on markflyhigh:python-split-postcommit into ** on apache:master**.

@aaltay
Copy link
Member

aaltay commented Oct 4, 2017

retest this please

1 similar comment
@markflyhigh
Copy link
Contributor Author

retest this please

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b7a116e on markflyhigh:python-split-postcommit into ** on apache:master**.

@markflyhigh
Copy link
Contributor Author

Python precommit failed on timeout. However, I checked log of sdk/python build, all tox build were executed and passed. Is it good for the testing? @aaltay

@aaltay
Copy link
Member

aaltay commented Oct 4, 2017

That is fine, I will merge it. Please pay attention to tests, after the merge. Do you know if there is a JIRA issue for the timeouts?

@asfgit asfgit closed this in afe8da8 Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants