[BEAM-2999] Move ValidatesRunner test out of Python postcommit#3927
[BEAM-2999] Move ValidatesRunner test out of Python postcommit#3927markflyhigh wants to merge 5 commits intoapache:masterfrom
Conversation
|
Run Seed Job |
|
Run Seed Job |
|
Run Python Dataflow ValidatesRunner |
|
+R: @aaltay |
|
Thank you @markflyhigh. I left a question for you. |
|
@aaltay um.. where is the question? looks like comments and JIRA are empty... |
sdks/python/run_postcommit.sh
Outdated
| @@ -70,22 +70,6 @@ SDK_LOCATION=$(find dist/apache-beam-*.tar.gz) | |||
| echo "pyhamcrest" > postcommit_requirements.txt | |||
| echo "mock" >> postcommit_requirements.txt | |||
There was a problem hiding this comment.
Do we still use postcommit_requirements.txt in this file?
There was a problem hiding this comment.
thanks for the catch. I checked existing validatesrunner tests and none of them use pyhamcrest and mock. Will remove it.
|
Forgot to post the question :), please take a look again. |
|
Run Python Dataflow ValidatesRunner |
|
LGTM. I can merge after tests pass. Could you also run the modified post commit tests? |
|
@aaltay I mistakenly remove |
|
Run Python Dataflow ValidatesRunner |
|
Run Python PostCommit |
|
Changes Unknown when pulling b7a116e on markflyhigh:python-split-postcommit into ** on apache:master**. |
|
retest this please |
1 similar comment
|
retest this please |
|
Changes Unknown when pulling b7a116e on markflyhigh:python-split-postcommit into ** on apache:master**. |
|
Python precommit failed on timeout. However, I checked log of sdk/python build, all tox build were executed and passed. Is it good for the testing? @aaltay |
|
That is fine, I will merge it. Please pay attention to tests, after the merge. Do you know if there is a JIRA issue for the timeouts? |
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.Create separate Jenkins build for Python validatesrunner tests and move them out of
beam_PostCommit_Python_Verify.beam_PostCommit_Python_Verifyis pretty heavy combining with unit tests, validatesrunner tests and end-to-end tests, and the total time increase to 1 hour recently. This change can reduce the load ofbeam_PostCommit_Python_Verifyand log will be cleaner for debugging if either build failed.