Skip to content

[BEAM-3156] Fix BigTableIO to use non-deprecated Futures.addCallback function#4095

Merged
chamikaramj merged 3 commits into
apache:masterfrom
rniemo-g:master
Nov 29, 2017
Merged

[BEAM-3156] Fix BigTableIO to use non-deprecated Futures.addCallback function#4095
chamikaramj merged 3 commits into
apache:masterfrom
rniemo-g:master

Conversation

@rniemo-g
Copy link
Copy Markdown
Contributor

@rniemo-g rniemo-g commented Nov 7, 2017

Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ x] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [ x] Each commit in the pull request should have a meaningful subject line and body.
  • [ x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • [x ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [x ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Jira issue: https://issues.apache.org/jira/browse/BEAM-3156
This PR changes which Futures.addCallback() overload we call. This is because the overload we're using is being deprecated.


@reuvenlax
Copy link
Copy Markdown
Contributor

lgtm

@chamikaramj
Copy link
Copy Markdown
Contributor

LGTM. I'll merge.

Thanks.

@chamikaramj
Copy link
Copy Markdown
Contributor

Run Java PreCommit.

@chamikaramj
Copy link
Copy Markdown
Contributor

Run Java PreCommit

@rniemo-g
Copy link
Copy Markdown
Contributor Author

Run Java PreCommit

@rniemo-g
Copy link
Copy Markdown
Contributor Author

It looks like the failed test was a timeout -- mind taking a look at this again?

@chamikaramj
Copy link
Copy Markdown
Contributor

Looks like Jenkins is stable now. I'll wait for the current run.

@chamikaramj chamikaramj merged commit 27f505e into apache:master Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants