[BEAM-3161] Cannot output with timestamp XXXX#4101
Closed
mingmxu wants to merge 1 commit intoapache:masterfrom
Closed
[BEAM-3161] Cannot output with timestamp XXXX#4101mingmxu wants to merge 1 commit intoapache:masterfrom
mingmxu wants to merge 1 commit intoapache:masterfrom
Conversation
xumingming
reviewed
Nov 9, 2017
| upstream = upstream.apply(stageName + "assignEventTimestamp", WithTimestamps | ||
| .of(new BeamAggregationTransforms.WindowTimestampFn(windowFieldIdx))) | ||
| .of(new BeamAggregationTransforms.WindowTimestampFn(windowFieldIdx)) | ||
| .withAllowedTimestampSkew(new Duration(Long.MAX_VALUE))) |
Contributor
There was a problem hiding this comment.
Two comments here:
- Will other DoFns we defined in BeamSQL have the similar issue? (The classes in
org.apache.beam.sdk.extensions.sql.impl.transformpackage) - In the future, the allowed timestamp skew might be better passed in as a config to the BeamSql api?(I am ok to keep it hardcoded in this PR.)
Author
There was a problem hiding this comment.
- This is the only place where we assign EventTimestamp explicitly;
- We may not need this parameter, now the optional aligned time in
tumble,hopandsessionis used as max_deplay_time;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R: @xumingming
CC: @takidau