Adds logging at INFO for all creation, deletion and copying of files in WriteFiles#4103
Closed
jkff wants to merge 1 commit intoapache:masterfrom
Closed
Adds logging at INFO for all creation, deletion and copying of files in WriteFiles#4103jkff wants to merge 1 commit intoapache:masterfrom
jkff wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help with debugging issues such as https://stackoverflow.com/questions/47113773/dataflow-2-1-0-streaming-application-is-not-cleaning-temp-folders/47142671
The amount of logging, I believe, should be reasonable: it's several messages per output file (not per element or anything like that): when the temp file is created, successfully closed, deleted on error, copied to final location, and deleted after copying. This should allow tracing everything that happens to suspicious files.
R: @chamikaramj