Skip to content

Remove obsolete dependence of FnApiRunner on MapTaskExecutorRunner.#4104

Closed
robertwb wants to merge 2 commits intoapache:masterfrom
robertwb:simplify
Closed

Remove obsolete dependence of FnApiRunner on MapTaskExecutorRunner.#4104
robertwb wants to merge 2 commits intoapache:masterfrom
robertwb:simplify

Conversation

@robertwb
Copy link
Contributor

@robertwb robertwb commented Nov 9, 2017

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@robertwb
Copy link
Contributor Author

robertwb commented Nov 9, 2017

R: @aaltay

@robertwb
Copy link
Contributor Author

The Java failures are irrelevant.

@aaltay
Copy link
Member

aaltay commented Nov 22, 2017

LGTM. Thank you @robertwb. This is awesome.

@asfgit asfgit closed this in b548e1f Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants