Update sdks/java/io/hadoop/jdk1.8-tests to run and pass for Gradle build.#4163
Closed
lukecwik wants to merge 1 commit intoapache:masterfrom
Closed
Update sdks/java/io/hadoop/jdk1.8-tests to run and pass for Gradle build.#4163lukecwik wants to merge 1 commit intoapache:masterfrom
lukecwik wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
R: @aaltay |
aaltay
reviewed
Nov 22, 2017
| // instead of a static port. | ||
| task createTargetDirectoryForCassandra() { | ||
| doLast { | ||
| if (!project.file("target").exists()) { |
Member
There was a problem hiding this comment.
Does it matter if this folder has left over files if it already exists?
Member
Author
There was a problem hiding this comment.
No. Its just a place for cassandra to dump content into while running an embedded instance.
Note the number of test failures decreased by 4 with this change. Only 3 failures in hbase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.