Update julia set example comments#4167
Merged
asfgit merged 1 commit intoapache:masterfrom Nov 22, 2017
Merged
Conversation
charlesccychen
approved these changes
Nov 22, 2017
Contributor
charlesccychen
left a comment
charlesccychen
left a comment
There was a problem hiding this comment.
Thanks, this LGTM.
| # ['apt-get', '--assume-yes', 'install', 'libjpeg62'], | ||
| # | ||
| # First, note that there is no need to use the sudo command because the setup | ||
| # script runs with appropriate access. |
Contributor
There was a problem hiding this comment.
Note: this line is Dataflow-specific until the FnAPI / containerization effort lands.
aaltay
commented
Nov 22, 2017
| # ['apt-get', '--assume-yes', 'install', 'libjpeg62'], | ||
| # | ||
| # First, note that there is no need to use the sudo command because the setup | ||
| # script runs with appropriate access. |
Member
Author
There was a problem hiding this comment.
charlesccychen wrote:
Note: this line is Dataflow-specific until the FnAPI / containerization effort lands.
Acknowledged. This needs some additional clean up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R: @charlesccychen