[BEAM-3348] Set utf-16 as SQL DSL default charset#4258
Conversation
|
R: @xumingmin |
|
retest this please |
ccca777 to
b0b8e4e
Compare
|
hi @xumingmin , I hava run |
|
retest this please. |
|
What's the motivation for UTF-16? Everywhere else we seem to use UTF-8. |
mingmxu
left a comment
There was a problem hiding this comment.
Given that Calcite only support UTF16 and ISO-8859-1(LATIN1)[1], this sounds a good option in SQL component, and it's also the solution in other projects like Flink[2].
@Alienero there're another two properties in SaffronProperties.java, is it safe to ignore them?
[1]. http://mail-archives.apache.org/mod_mbox/calcite-dev/201710.mbox/%3CCAPSgeETv5aJ3GKAkoYhCN7oihu9cNLwwLFrs7AsTmC-9WTk2aw@mail.gmail.com%3E
[2]. https://issues.apache.org/jira/browse/FLINK-7451
feat: support national charset
|
hi @xumingmin,I made some additions: add default R: @xumingmin |
|
retest this please |
|
retest this please |
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.