Skip to content

Comments

[BEAM-3369] Fix typehint errors introduced in PR #4282.#4292

Merged
robertwb merged 1 commit intoapache:masterfrom
robertwb:BEAM-3369
Dec 19, 2017
Merged

[BEAM-3369] Fix typehint errors introduced in PR #4282.#4292
robertwb merged 1 commit intoapache:masterfrom
robertwb:BEAM-3369

Conversation

@robertwb
Copy link
Contributor

This gets the tests passing (and fixes the lint error).
A more principled fix will be in a follow-up PR.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

This gets the tests passing (and fixes the lint error).
A more principled fix will be in a follow-up PR.
@robertwb
Copy link
Contributor Author

R: @chamikaramj

@chamikaramj
Copy link
Contributor

LGTM

@robertwb robertwb merged commit 0aa943d into apache:master Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants