[BEAM-2732] Logging relies on statesampler state#4395
Closed
pabloem wants to merge 3 commits intoapache:masterfrom
Closed
[BEAM-2732] Logging relies on statesampler state#4395pabloem wants to merge 3 commits intoapache:masterfrom
pabloem wants to merge 3 commits intoapache:masterfrom
Conversation
pabloem
force-pushed
the
global-sampler-logging
branch
from
ab83d9b to
e7c258f
Compare
Member
Author
|
Run Python PostCommit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on PR #4375, and PR #4387.
This PR is a backward-compatible change that allows logging to rely on statesampler state to provide the current step name.
This change should enable all clients to stop using the legacy logging to switch state across every operation, and start using statesampler for that.
This change should not have a significant performance impact, as JsonLogFormatter was already relying on a Thread local to retrieve the logging information.