[BEAM-3754]: Fix readBytes() initialization in KafkaIO#4792
Merged
mingmxu merged 1 commit intoapache:masterfrom Mar 4, 2018
Merged
[BEAM-3754]: Fix readBytes() initialization in KafkaIO#4792mingmxu merged 1 commit intoapache:masterfrom
mingmxu merged 1 commit intoapache:masterfrom
Conversation
mingmxu
approved these changes
Mar 3, 2018
mingmxu
left a comment
mingmxu
left a comment
There was a problem hiding this comment.
LGTM, more clear now to share the same settings.
will merge after CI passes
Contributor
Author
|
Thansk @xumingmin. Next time I will wait till the tests pass before asking for review. Sorry about that. |
rmannibucau
pushed a commit
to rmannibucau/incubator-beam
that referenced
this pull request
Apr 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readBytes()should invokeread()rather than duplicating code (as suggested by the reporter in BEAM-3754). Onlyread()was updated with recent changes and caused a check failure.Also made sure that this constructor is invoked in one of the tests.
+R: @xumingmin