Skip to content

[BEAM-3882] Fix StateRequestHandler interface to be idiomatic#4900

Merged
tgroh merged 1 commit intoapache:masterfrom
axelmagn:fix-state-request-handler-interface
Mar 20, 2018
Merged

[BEAM-3882] Fix StateRequestHandler interface to be idiomatic#4900
tgroh merged 1 commit intoapache:masterfrom
axelmagn:fix-state-request-handler-interface

Conversation

@axelmagn
Copy link
Contributor

The previous implementation of StateRequestHandler did not conform
to Beam coding conventions. It should not have accepted a return
value as a parameter. This fix updates the interface to instead
return a CompletableStage.

R: @tgroh
CC: @aljoscha, @bsidhom, @lukecwik


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

The previous implementation of StateRequestHandler did not conform
to Beam coding conventions.  It should not have accepted a return
value as a parameter.  This fix updates the interface to instead
return a CompletableStage.
@axelmagn axelmagn force-pushed the fix-state-request-handler-interface branch from 497aad6 to c526f6b Compare March 19, 2018 23:32
@tgroh tgroh merged commit 16d176b into apache:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants