[BEAM-3951] Migrate container instructions and builds to Gradle#4958
[BEAM-3951] Migrate container instructions and builds to Gradle#4958lukecwik merged 3 commits intoapache:masterfrom
Conversation
herohde
commented
Mar 27, 2018
herohde
commented
- Also move out Go examples for build performance
* Also move out Go examples for build performance
|
R: @lukecwik |
herohde
changed the title
build_rules.gradle
Outdated
| } | ||
| } | ||
|
|
||
| def containerImageName(name) { |
There was a problem hiding this comment.
Add method comment.
Interesting that def works, before I was sticking everything onto ext. This seems much cleaner. Consider swapping all usages of ext.fooBar = {} to def fooBar
There was a problem hiding this comment.
Added. I also stick it into ext below.
sdks/CONTAINERS.md
Outdated
|
|
||
| Similarly for the Java SDK harness container image. If you want to push the same image | ||
| Similarly for the Java and Go SDK harness container images. If you want to push the same image | ||
| to multiple registries, you can retagging the image using `docker tag` and push. |
| } | ||
| name "${repositoryRoot}/go:latest" | ||
| name containerImageName("go") | ||
| files "./build/" |
There was a problem hiding this comment.
Note that with this setup we are building the boot binary multiple times, once per container. Not a blocking issue, just an observation.
There was a problem hiding this comment.
Not sure I understand what you mean. We are only building one container image, like before.
There was a problem hiding this comment.
We have the same golang definition to build the boot.go binary in sdks/java/container, sdks/go/container, and sdks/python/container.
There was a problem hiding this comment.
They are different boot.go files.
|
Thanks @lukecwik. PTAL |
|
Updated the helper function. @lukecwik PTAL |
2 participants
