[BEAM-3257] Add Python precommit gradle config#5010
Merged
lukecwik merged 2 commits intoapache:masterfrom Apr 5, 2018
Merged
Conversation
Member
Author
|
R: @lukecwik |
udim
changed the title
Member
Author
|
update seed job |
Member
Author
|
run seed job |
lukecwik
requested changes
Apr 3, 2018
sdks/python/build.gradle
Outdated
| args '-c', "source ${envdir}/bin/activate && pip install --upgrade tox" | ||
| } | ||
| } | ||
| outputs.files("$buildDir/.gradleenv/bin/tox") |
Member
There was a problem hiding this comment.
re-use the definition of envdir here.
sdks/python/build.gradle
Outdated
| } | ||
|
|
||
| task sdist { | ||
| task sdist (dependsOn: 'setupVirtualenv') { |
Member
There was a problem hiding this comment.
nit: remove the space between task name and arguments since its a method call like sdist(dependsOn: 'setupVirtualenv') { here and below.
|
|
||
| // Publish all test results to Jenkins | ||
| publishers { | ||
| archiveJunit('**/build/test-results/**/*.xml') |
Member
There was a problem hiding this comment.
This doesn't seem to make sense. We should be publishing the python tests.
Member
Author
|
run seed job |
lukecwik
approved these changes
Apr 3, 2018
Member
Author
|
run seed job |
Member
Author
|
run seed job |
1 similar comment
Member
Author
|
run seed job |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION HERE
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.