[BEAM-4024] Fix AttributeError in BundleBasedDirectRunner#5035
Merged
aaltay merged 1 commit intoapache:masterfrom Apr 6, 2018
Merged
[BEAM-4024] Fix AttributeError in BundleBasedDirectRunner#5035aaltay merged 1 commit intoapache:masterfrom
aaltay merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
R: @aaltay |
Member
|
Thank you LGTM. Should we run at least some batch unit tests with BundleBasedDirectRunner to prevent regressions? |
Contributor
Author
|
retest this please |
Contributor
Author
|
@aaltay: I have filed https://issues.apache.org/jira/browse/BEAM-4029 for adding additional tests. |
Member
|
Thank you. I will merge once tests here pass. |
Contributor
Author
|
retest this please |
Member
|
I will merge this based on passed gradle python precommit tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes an AttributeError in the BundleBasedDirectRunner (see https://issues.apache.org/jira/browse/BEAM-4024).