[BEAM-4019] Refactor HBaseIO splitting to produce ByteKeyRange objects#5081
Merged
iemejia merged 1 commit intoapache:masterfrom Apr 18, 2018
Merged
Conversation
Member
Author
aromanenko-dev
approved these changes
Apr 10, 2018
Contributor
aromanenko-dev
left a comment
aromanenko-dev
left a comment
There was a problem hiding this comment.
LGTM, just a minor comment
|
|
||
| /** Utils to interact with an HBase cluster and get information on tables/regions. */ | ||
| class HBaseUtils { | ||
|
|
Contributor
There was a problem hiding this comment.
Please, add JavaDoc for this method that explains how it works
Member
Author
There was a problem hiding this comment.
Thanks, added docs in all methods of utils.
iemejia
force-pushed
the
BEAM-4019-hbaseio-bytekeyrange-refactor
branch
2 times, most recently
from
1d8ee39 to
fd79ee9
Compare
tweise
approved these changes
Apr 13, 2018
| regionLocations, read.tableId, read.serializableScan.get()); | ||
| final int numSources = ranges.size(); | ||
| LOG.debug("Spliting into {} source(s)", numSources); | ||
| if (numSources >= 1) { |
iemejia
force-pushed
the
BEAM-4019-hbaseio-bytekeyrange-refactor
branch
from
fd79ee9 to
5241c07
Compare
Member
Author
|
Ok rebased and merged, this is good to go now. I will wait for Jenkins to be happy and then merge, thanks @aromanenko-dev and @tweise for the review. |
iemejia
force-pushed
the
BEAM-4019-hbaseio-bytekeyrange-refactor
branch
from
5241c07 to
80982b0
Compare
Member
Author
|
Jenkins break is unrelated so I am merging it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some context this is an internal refactor towards a SDF based translation of HBase read, it is just internals. I extracted most (if not all) HBase region/split related methods into an individual class
HBaseUtilstoo. I did not create an additional unit test for that one since it is well covered by HBaseIOTest and I did not want to add additional extra time to the build..