[BEAM-4028] Transitioning MapTask objects to NameContext#5135
Merged
aaltay merged 2 commits intoapache:masterfrom Apr 27, 2018
Merged
[BEAM-4028] Transitioning MapTask objects to NameContext#5135aaltay merged 2 commits intoapache:masterfrom
aaltay merged 2 commits intoapache:masterfrom
Conversation
Member
Author
|
Run Python PostCommit |
Member
Author
|
Retest this please. |
pabloem
force-pushed
the
more-namecontext
branch
3 times, most recently
from
1a76a19 to
461d1d4
Compare
Member
Author
|
Run Python PostCommit |
aaltay
approved these changes
Apr 20, 2018
Member
aaltay
left a comment
aaltay
left a comment
There was a problem hiding this comment.
LGTM. My only concern is that we are adding bunch of Dataflow only looking code out of dataflow runner code. We should consider finding a better home for those pieces eventually.
Member
Author
|
I understand. The goal of NameContext is to isolate naming concerns as much as possible, so that any runner (dataflow / portability) needs only to provide an instance of NameContext. Once this is pulled in to Dataflow, I expect DataflowNameContext won't be needed in the shared beam code (only in the worker code that translates from map task) |
pabloem
force-pushed
the
more-namecontext
branch
from
461d1d4 to
c7b8517
Compare
Member
Author
|
Ran seed job to update for changes from #5214 |
Member
Author
|
Run Seed Job |
Member
Author
|
Retest this please |
Member
Author
|
I believe this is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transitioning the
operation_specs.MapTaskto rely fully onNameContextfor step naming.r: @aaltay
The plan is to use NameContext wherever we need a step name (e.g. operations, ssampler), instead of passing operation_name, step_name etc around like we do atm. Classes were created in #5043, and this is further progress.
Followup will be internal changes in dataflow code to rely on and pass NameContexts around.