[BEAM-3268] Reshuffle filenames before returning them from WriteFilesResult#5159
Merged
jkff merged 1 commit intoapache:masterfrom Apr 20, 2018
Merged
[BEAM-3268] Reshuffle filenames before returning them from WriteFilesResult#5159jkff merged 1 commit intoapache:masterfrom
jkff merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
retest this please |
lgajowy
requested changes
Apr 18, 2018
Contributor
lgajowy
left a comment
lgajowy
left a comment
There was a problem hiding this comment.
Thanks for this PR! I added my suggestions.
| .withPrefix("birds") | ||
| .withSuffix(".xml")) | ||
| .getPerDestinationOutputFilenames() | ||
| .apply("Prevent fusion", Reshuffle.viaRandomKey()) |
Contributor
There was a problem hiding this comment.
Please delete the unused Reshuffle's import (checkstyle fails).
| // Verify that files exist. | ||
| for (String filename : values) { | ||
| FileSystems.match(filename, EmptyMatchTreatment.DISALLOW); | ||
| } |
Contributor
There was a problem hiding this comment.
Wouldn't it be better to have it tested in WriteFilesTest instead of TextIOWriteTest?
jkff
force-pushed
the
reshuffle-filenames
branch
from
0e2cf38 to
8bd2035
Compare
Contributor
Author
|
Thanks Lukasz! I deleted the import and moved verification of file existence into WriteFilesTest (and removed from TextIOWriteTest as it's no longer responsibility of that test to test this) |
Contributor
|
retest this please |
Contributor
Author
|
OK seems tests went through this time. |
Contributor
|
(I have no write access so I cannot merge this :) ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R: @lgajowy
CC: @chamikaramj @udim