[BEAM-3433] Allow a GCP project to be explicitly set for a load job#5178
Merged
jkff merged 3 commits intoapache:masterfrom May 17, 2018
Merged
[BEAM-3433] Allow a GCP project to be explicitly set for a load job#5178jkff merged 3 commits intoapache:masterfrom
jkff merged 3 commits intoapache:masterfrom
Conversation
…nferring from the destination table.
Author
|
Hi @chamikaramj , can you please take a look? |
chamikaramj
requested review from
chamikaramj and
jkff
and removed request for
jkff
Contributor
|
Thanks. Will take a look. cc: @jkff |
jkff
requested changes
Apr 27, 2018
| * the write method is set to {@link Method#FILE_LOADS}. If omitted, the project of the | ||
| * destination table is used. | ||
| */ | ||
| public Write<T> withLoadJobProjectId(String loadJobProjectId) { |
Contributor
There was a problem hiding this comment.
Could you add a ValueProvider version too?
Contributor
|
Hey @kvncp , any updates on this one? |
Contributor
|
@kvncp, please address comments to get this into next release. |
Author
|
Sorry, was on vacation recently and just catching up here. Addressing comments now! |
Author
|
@jfkk, @chamikaramj, I've addressed comments, and tests are passing. |
Contributor
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the needed string parameter to the BigQueryIO.write() function, and passed it through to the underlying class. Wanted to get some feedback before trying to write a test.