[BEAM-3886] Have the Python SDK use the state api service descriptor on the process bundle descriptor.#5192
Merged
Merged
Conversation
tweise
force-pushed
the
BEAM-3886.stateAPI
branch
from
cc26de8 to
f1cdab3
Compare
tweise
force-pushed
the
BEAM-3886.stateAPI
branch
from
f1cdab3 to
5b8c9bb
Compare
10 tasks
Contributor
|
Looks like the maven archetype is failing for some reason. I don't think this could have caused that though. |
…descriptor on the process bundle descriptor.
tweise
force-pushed
the
BEAM-3886.stateAPI
branch
from
5b8c9bb to
4967d8d
Compare
robertwb
approved these changes
Apr 20, 2018
Contributor
robertwb
left a comment
robertwb
left a comment
There was a problem hiding this comment.
Thanks for following up on this. Still looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the commit from @lukecwik that I rebased and tested with the portable Flink runner on the hacking-job-server branch. Without this change, the SDK cannot communicate with the runner.
CC: @bsidhom @aaltay @robertwb
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue../gradlew buildto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.