Skip to content

[BEAM-4066] Fix Nexmark fails when running with PubSub#5202

Merged
iemejia merged 1 commit intoapache:masterfrom
aromanenko-dev:BEAM-4066_Nexmark_PubSub
Apr 24, 2018
Merged

[BEAM-4066] Fix Nexmark fails when running with PubSub#5202
iemejia merged 1 commit intoapache:masterfrom
aromanenko-dev:BEAM-4066_Nexmark_PubSub

Conversation

@aromanenko-dev
Copy link
Contributor

Anonymous inner class for DoFn is not serialisable, so they were extracted into inner ones.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run ./gradlew build to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@aromanenko-dev
Copy link
Contributor Author

R: @rangadi

Copy link
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iemejia iemejia merged commit feb1027 into apache:master Apr 24, 2018
@rangadi
Copy link
Contributor

rangadi commented Apr 24, 2018

LGTM. Thanks @aromanenko-dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants