[BEAM-4073] Migrate DirectRunner Evaluators to use Portable Graph Components#5271
Merged
tgroh merged 4 commits intoapache:masterfrom May 15, 2018
Merged
Conversation
tgroh
force-pushed
the
migrate_evaluators_portability
branch
6 times, most recently
from
5283222 to
1104a73
Compare
Member
Author
|
R: @youngoli |
tgroh
force-pushed
the
migrate_evaluators_portability
branch
from
1104a73 to
c580674
Compare
tgroh
force-pushed
the
migrate_evaluators_portability
branch
from
c580674 to
8007954
Compare
youngoli
approved these changes
May 15, 2018
Contributor
youngoli
left a comment
youngoli
left a comment
There was a problem hiding this comment.
Not super familiar with the codebase, so I may have missed some subtle issues, but otherwise looks good to me.
Member
Author
|
run java precommit - flink failed, but that shouldn't be affected by this change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrates the Impulse, Flatten, and GroupByKeyOnly evaluators to use information
extracted from the portable graph.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue../gradlew buildto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.