[BEAM-4031] Add labels flag to Go SDK Dataflow Runner.#5272
Merged
Conversation
Signed-off-by: Jason Kuster <jasonkuster@google.com>
Contributor
Author
|
R: @herohde |
herohde
reviewed
May 3, 2018
| var jobLabels map[string]string | ||
| if *labels != "" { | ||
| if err := json.Unmarshal([]byte(*labels), &jobLabels); err != nil { | ||
| return err |
herohde
approved these changes
May 3, 2018
herohde
left a comment
herohde
left a comment
Contributor
There was a problem hiding this comment.
LGTM with one minor comment
Signed-off-by: Jason Kuster <jasonkuster@google.com>
Contributor
Author
|
@tgroh can you give this a quick look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jason Kuster jasonkuster@google.com
Add labels flag to Go SDK Dataflow Runner.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue../gradlew buildto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.