Improving metrics api - execution separation.#5304
Closed
pabloem wants to merge 3 commits into
Closed
Conversation
Member
Author
|
Run Python PostCommit |
Member
Author
|
Postcommit failed due to docs (strangely, precommit passed the same test) - I'm investigating |
aaltay
approved these changes
May 9, 2018
Member
Author
|
Run Python PostCommit |
1 similar comment
Member
Author
|
Run Python PostCommit |
Member
Author
|
Run Python PostCommit |
Member
Author
|
This is causing trouble in Dataflow, so I'll close the change for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue has caused trouble in the current Apache Beam import process.
This PR gives Metrics the responsibility of attaching itself to statesampler for state tracking, instead of statesampler initializing metrics, which is somewhat awkward.
Metrics execution infrastructure is initialized only when metrics are to be used, and not when the metrics api is imported.
r: @aaltay