Skip to content

[BEAM-1755] Add a directory with build-specific scripts to clear up the Python SDK dir#5400

Merged
pabloem merged 3 commits intoapache:masterfrom
pabloem:script-dir
May 22, 2018
Merged

[BEAM-1755] Add a directory with build-specific scripts to clear up the Python SDK dir#5400
pabloem merged 3 commits intoapache:masterfrom
pabloem:script-dir

Conversation

@pabloem
Copy link
Member

@pabloem pabloem commented May 17, 2018

r: @tvalentyn
This is just a proposal. Let me know if you think it makes sense.

@pabloem
Copy link
Member Author

pabloem commented May 17, 2018

Run Python PostCommit

1 similar comment
@pabloem
Copy link
Member Author

pabloem commented May 17, 2018

Run Python PostCommit

@tvalentyn
Copy link
Contributor

tvalentyn commented May 17, 2018

Makes sense to me; you could also call the folder testing instead of scripts, although generate_pydoc.sh would have to stay or go into a different place.

@pabloem
Copy link
Member Author

pabloem commented May 17, 2018

I think it makes sense to have all of them in a single place, so new ones will not be reimplemented. WDYT?

@pabloem
Copy link
Member Author

pabloem commented May 18, 2018

@tvalentyn

@tvalentyn
Copy link
Contributor

Giving folders meaningful names could be more mnemonic as it to the purpose of the content in the folder, but I don't have a strong opinion on this; in fact I have a scripts folder on my dev box that serves a similar purpose. Your call.

@tvalentyn
Copy link
Contributor

And, thanks for the ping, I missed the previous update.

@charlesccychen
Copy link
Contributor

It seems like with this change, you would still need to run scripts with the current directory as sdks/python and do scripts/[...].sh. In particular, if you run the script in the sdks/python/scripts directory directly, it looks like many of the scripts just won't work, and this isn't documented, since it looks like the scripts depend on the current working directory. Is it possible to fix this so that it works both ways?

@pabloem
Copy link
Member Author

pabloem commented May 21, 2018

I've added code in all scripts to check and switch their current directory. PTAL.

@pabloem
Copy link
Member Author

pabloem commented May 21, 2018

Run Python PostCommit

@tvalentyn
Copy link
Contributor

LGTM

@pabloem pabloem merged commit bf35bd2 into apache:master May 22, 2018
@pabloem pabloem deleted the script-dir branch May 22, 2018 17:33
boyuanzz pushed a commit to boyuanzz/beam that referenced this pull request May 24, 2018
…he Python SDK dir (apache#5400)

* Moving Python Bash scripts to own directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments