Skip to content

Conversation

@swegner
Copy link
Contributor

@swegner swegner commented May 17, 2018

http://imperceptiblethoughts.com/shadow/#change_log

This is an attempt to fix release build issues described in BEAM-4328. I don't have any confidence that it fixes the build. But it might, and it's general goodness to keep our dependencies up-to-date.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand:
    • What the pull request does
    • Why it does it
    • How it does it
    • Why this approach
  • Each commit in the pull request should have a meaningful subject line and body.
  • Run ./gradlew build to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@swegner
Copy link
Contributor Author

swegner commented May 17, 2018

R: @pabloem

CC: @boyuanzz @lukecwik

@pabloem
Copy link
Member

pabloem commented May 17, 2018

LGTM. I'll merge after getting passing precommit.

@swegner
Copy link
Contributor Author

swegner commented May 17, 2018

Java pre-commits fail on task :beam-sdks-java-maven-archetypes-starter:generateAndBuildArchetypeTest: https://builds.apache.org/job/beam_PreCommit_Java_GradleBuild/5505/

@pabloem points out that this also failed on another PR which doesn't change Java: https://scans.gradle.com/s/kr23q43mh6fmk

@swegner
Copy link
Contributor Author

swegner commented May 17, 2018

Run Java PreCommit

@pabloem
Copy link
Member

pabloem commented May 17, 2018

Nice. Merging.

@pabloem pabloem merged commit 5a942f6 into apache:master May 17, 2018
@swegner swegner deleted the upgrade_shadow_plugin branch May 23, 2018 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants