[BEAM-3669] clean generated files prior to lint#5527
Merged
pabloem merged 1 commit intoapache:masterfrom May 31, 2018
brucearctor:master
Merged
[BEAM-3669] clean generated files prior to lint#5527pabloem merged 1 commit intoapache:masterfrom brucearctor:master
pabloem merged 1 commit intoapache:masterfrom
brucearctor:master
Conversation
Member
|
This LGTM. I am trying to reproduce on my machine, to make sure that this change will fix it. |
Member
|
To reproduce: |
Member
|
Okay, I've reproduced and verified that this fixes the issue, when running with tox. Thanks Austin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing/Cleaning up Tox and Lint error when there is generated cython files.
@pabloem