[BEAM-4326] Enforce ErrorProne analysis in the fn-execution project#5542
Merged
iemejia merged 1 commit intoapache:masterfrom Jun 7, 2018
Merged
Conversation
cademarkegard
force-pushed
the
beam4326/errorprone-fn-execution
branch
from
c05076e to
a6f26ed
Compare
Contributor
Author
swegner
requested changes
Jun 4, 2018
Contributor
swegner
left a comment
swegner
left a comment
There was a problem hiding this comment.
Looks pretty good; as a general comment, it's valuable to have a comment explaining analysis suppressions. That let's future readers understand why the suppression is safe, and to re-evaluate whether it still applies as the code gets maintained.
| } | ||
|
|
||
| @Test | ||
| @SuppressWarnings("FutureReturnValueIgnored") |
Contributor
There was a problem hiding this comment.
Can you add a brief comment describing why this suppression is safe?
| } | ||
|
|
||
| @Test | ||
| @SuppressWarnings("FutureReturnValueIgnored") |
Contributor
There was a problem hiding this comment.
Can you add a brief comment describing why this suppression is safe?
cademarkegard
force-pushed
the
beam4326/errorprone-fn-execution
branch
from
a6f26ed to
107287e
Compare
Contributor
Author
|
run java precommit |
Contributor
Author
|
run python precommit |
Contributor
Author
|
@swegner thanks for the review! I addressed the pending items and got the tests to pass. |
Contributor
|
Thanks, this looks good to me! Passing over to a committer to merge.. @lukecwik can you help? |
Contributor
Author
|
thanks @swegner ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
failOnWarningforfn-executionproject