Skip to content

Conversation

@swegner
Copy link
Contributor

@swegner swegner commented Jun 12, 2018

POM generation APIs were improved in Gradle 4.8; this change takes
advantage of new DSL APIs to define generated POM metadata when
available. Some metadata (notably dependencies) still need to be
directly added to the XML.


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

POM generation APIs were improved in Gradle 4.8; this change takes
advantage of new DSL APIs to define generated POM metadata when
available. Some metadata (notably dependencies) still need to be
directly added to the XML.
@swegner
Copy link
Contributor Author

swegner commented Jun 12, 2018

I did a manual diff of the before-and-after of this change; a couple of the sections get re-ordered in the POM but otherwise the content is identical.

./gradlew :beam-sdks-java-core:publishToMavenLocal -Ppublishing && meld \
    pom_diff/before.xml  \
    ~/.m2/repository/org/apache/beam/beam-sdks-java-core/2.6.0-SNAPSHOT/beam-sdks-java-core-2.6.0-SNAPSHOT.pom

R: @lukecwik

@lukecwik lukecwik self-requested a review June 12, 2018 18:44
@lukecwik
Copy link
Member

This is pretty sweet clean-up.

@lukecwik lukecwik merged commit fad6554 into apache:master Jun 12, 2018
@swegner swegner deleted the gradle_48 branch June 13, 2018 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants