[BEAM-4641] Samza runner postcommit status in PR template#5785
[BEAM-4641] Samza runner postcommit status in PR template#5785iemejia merged 2 commits intoapache:masterfrom
Conversation
iemejia
left a comment
iemejia
left a comment
There was a problem hiding this comment.
Hi want to nitpick about two things:
-
Can we get the runners part to be vertical so we have something like (so we don't break layout):
| Lang | Status | Runner | Status |
| Go | ... | Apex | ... |
... -
Can you try to put it in lexicographical order so (Samza would be before Spark).
|
@iemejia : It makes a lot of sense to keep the lexicographical order. I updated the pr for it. For your first comment, it seems to the current way of displaying runners horizontally makes the visualization nicer to me and fits the screen better. It also matches the layout in the capability matrix. If there is no strong opinion, I would like to keep as it is. |
| --- | --- | --- | --- | --- | --- | --- | --- | ||
| Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- | ||
| Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/) | ||
| Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | --- |
There was a problem hiding this comment.
It's probably really hard to see from this diff, but there is an extra "| ---" in there :). Previous it has 3 "---" in the end, now we have 4. I double checked in the html rendering in intellij and it looks ok. Thanks for paying attention!
There was a problem hiding this comment.
you are right sorry for the confusion.
|
Sure, let's see how it looks when merged but well with more runners putting things to the right won't scale. |
2 participants
Please add a meaningful description for your change here
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)