Skip to content

BEAM-4562: [SQL] Fix INSERT VALUES in JDBC#5918

Merged
mingmxu merged 2 commits into
apache:masterfrom
apilloud:hook
Jul 11, 2018
Merged

BEAM-4562: [SQL] Fix INSERT VALUES in JDBC#5918
mingmxu merged 2 commits into
apache:masterfrom
apilloud:hook

Conversation

@apilloud
Copy link
Copy Markdown
Member

@apilloud apilloud commented Jul 10, 2018

Fixes BEAM-4562: INSERT values not working


Follow this checklist to help us incorporate your contribution quickly and easily:

  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status Build Status Build Status Build Status
Python Build Status --- Build Status
Build Status
--- --- --- ---

@apilloud apilloud changed the title BEAM-4562 BEAM-4700: [SQL] Fix INSERT VALUES and timezone issues BEAM-4562 BEAM-4700: [SQL] Fix INSERT VALUES and timezone issues in JDBC Jul 10, 2018
@apilloud
Copy link
Copy Markdown
Member Author

R: @akedin
cc: @amaliujia

@apilloud apilloud changed the title BEAM-4562 BEAM-4700: [SQL] Fix INSERT VALUES and timezone issues in JDBC BEAM-4562: [SQL] Fix INSERT VALUES in JDBC Jul 10, 2018
@akedin
Copy link
Copy Markdown
Contributor

akedin commented Jul 10, 2018

LGTM

@apilloud
Copy link
Copy Markdown
Member Author

R: @xumingmin Can you be the committer for this?

Copy link
Copy Markdown

@mingmxu mingmxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging

@mingmxu mingmxu merged commit 39db610 into apache:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants